Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move well known cloud provider taints to k8s.io/cloud-provider/api #88435

Merged
merged 1 commit into from
Feb 26, 2020
Merged

move well known cloud provider taints to k8s.io/cloud-provider/api #88435

merged 1 commit into from
Feb 26, 2020

Conversation

andrewsykim
Copy link
Member

Signed-off-by: andrewsykim kiman@vmware.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Moves well known cloud provider taints from pkg/scheduler/api to k8s.io/cloud-provider/api. This is part of an effort to remove internal deps in all cloud controllers so they can be moved to a staging repo.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 23, 2020
@andrewsykim
Copy link
Member Author

/assign @liggitt @cheftako
/sig cloud-provider
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/cloudprovider area/kubelet sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 23, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 23, 2020
mattjmcnaughton
mattjmcnaughton reviewed Feb 23, 2020
View reviewed changes
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from sig-node perspective. I don't think we have any opinions around whether we import these values from pkg/scheduler or pkg/cloud-provider. It looks like we already depend on both :)

@mattjmcnaughton
Copy link
Contributor

/retest

@cheftako
Copy link
Member

Vendor Verify failed.
If you're seeing this locally, run the below command to fix your directories:
hack/update-vendor.sh

@andrewsykim
move well known cloud provider taints to k8s.io/cloud-provider/api
8c63335 
Signed-off-by: andrewsykim <kim.andrewsy@gmail.com>
@andrewsykim
Copy link
Member Author

/retest

@ahg-g
Copy link
Member

ahg-g commented Feb 24, 2020

/approve

for the scheduler changes.

cheftako
cheftako reviewed Feb 24, 2020
View reviewed changes
Copy link
Member

@cheftako cheftako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2020
@andrewsykim
Copy link
Member Author

ref #81172

@liggitt
Copy link
Member

liggitt commented Feb 26, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, andrewsykim, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit a726c9c into kubernetes:master Feb 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 26, 2020
@k8s-ci-robot k8s-ci-robot mentioned this pull request May 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako left review comments

@mattjmcnaughton mattjmcnaughton mattjmcnaughton left review comments

@dims dims Awaiting requested review from dims

@draveness draveness Awaiting requested review from draveness

Assignees

@cheftako cheftako

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andrewsykim @mattjmcnaughton @cheftako @ahg-g @liggitt @k8s-ci-robot